View source for RetroWikipedia:Code review

{{information page|WP:CREV|WP:CODEREV}}
[[File:Nuvola apps important JS.svg|right|80px]]
RetroWikipedia's '''code review''' process is a way to receive feedback from other editors about new or proposed changes to a [[WP:US|user script]] or [[WP:Gadget|Gadget]]. Such changes would usually be proposed by the script's maintainer, unless they are inactive. Other editors can comment on the changes or new script. This process may be used prior to making an edit request for a script in the MediaWiki namespace (which can only be edited by [[RetroWikipedia:interface administrators|interface administrators]]). Code review is a useful place to centralise reviews from other editors.

Code reviews are entirely voluntary, open to any feedback, and nominators may also request feedback for specific issues. Editors and nominators may both edit articles during the discussion. Compared to real-world [[code review]] process, where experts themselves take part in reviewing the work of another, the volunteers here do not necessarily have qualifications or professional experience in coding. There are also no mandatory coding conventions, though it is suggested that a script be internally consistent in whatever conventions it does use.

__TOC__

== About ==
;{{tick}} Do use code review for:
:* Proposed changes to RetroWikipedia userscript
:* Proposed changes to RetroWikipedia gadgets
:* Proposed changes to pages related to a script, such as JSON or CSS pages
:* Review of new user scripts or gadgets
;{{cross}} Do not use code review for:
:* General help with programming
:* Scripts which are unrelated to RetroWikipedia
:* Scripts that you would like created
:* Non-code pages, such as articles
:* Lua modules

== Process ==
;Requesting a review
:See the [[#Instructions|instructions below]]. Nominators are limited to one review at a time, and are encouraged to help reduce the backlog by commenting on other reviews. Any editor may comment on a review, and there is no requirement that any comment be acted on.
;When reviewing
:*Generally, follow the [[mw:Gerrit/Code review|MediaWiki Code review guidance]], as much as is applicable to userscripts and gadgets
:*Only use headings that are level 4 (<kbd>==== heading ====</kbd>) and below 
:*To show snippets of code with nice formatting, use <code><nowiki><syntaxhighlight lang="js"></nowiki></code>. The lang attribute can also take <kbd>css</kbd> for CSS, and <kbd>json</kbd> for JSON
:*You can use {{tlx|+1}} to generate {{+1}}, or {{tlx|-n}} to generate {{-n}}
:*It is not generally appropriate to use "+2" or "-2", as this code review process is entirely voluntary, and the decision on whether to make changes is ultimately up to the script's author (for userscripts), or an interface admin (for gadgets)
;Closing a code review
:Close reviews when they are resolved, or it has been 14 days since the last comment
:#Add {{tlx|archive top}} and {{tlx|archive bottom}} templates to the top and bottom of the review page
:#Remove the subpage transclusion from this page
:#Add a new entry to [[RetroWikipedia:Code review/archive]]

==Instructions==
# Create a code review subpage. Use the box below, adding the script's name after {{tt|Code review/}}. If a previous code review already exists, add or increment a number at the end: <kbd>MyScript 2</kbd>,  <kbd>MyScript 3</kbd>, etc.
#:<InputBox>
type=create
default=Code review/
prefix=RetroWikipedia:
preload=Template:Code review/preload
buttonlabel=Create new code review subpage
</InputBox>
# Add the following details to the subpage:
#*Link to existing code
#*Link to proposed code
#*Diff link, using {{tlx|Compare pages|page1|page2}}
#*Summary of you propose to change, and why
#*Specific issues, if any, you would like feedback on
#Transclude the subpage you created to the TOP of the next section of this page, by adding <code><nowiki>{{RetroWikipedia:Code review/</nowiki></code><kbd>''YOUR SUBPAGE''</kbd><code><nowiki>}}</nowiki></code>

==Open code reviews==
<!-- List new  reviews at the TOP of this section, directly below this line -->